apollo_dashboard: fix additional conflicting alert names #12431
+26
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
idan-starkware
approved these changes
Feb 9, 2026
Contributor
idan-starkware
left a comment
idan-starkware
left a comment
There was a problem hiding this comment.
@idan-starkware reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).
idan-starkware
approved these changes
Feb 9, 2026
Contributor
idan-starkware
left a comment
idan-starkware
left a comment
There was a problem hiding this comment.
Reviewable status:
graphite-app
bot
changed the base branch from
02-09-apollo_dashboard_rename_state_sync_stuck_long_time_alert
to
graphite-base/12431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Changes are limited to alert metadata/placeholder naming and title casing; primary risk is breaking references to old alert/placeholder names in Grafana or downstream tooling.
Overview
Resolves additional Grafana alert-name conflicts by switching several
block_production_haltalerts to derive their internalname(and related placeholder keys like sampling window/severity) from the human-readabletitlevia a normalized lowercase/underscore format.Updates
dev_grafana_alerts.jsonto use distinct, consistently-cased titles for the affected alerts (batched transactions stuck, consensus block number stuck, and consensus P2P quorum peers), aligning dashboard definitions with the new naming scheme.Written by Cursor Bugbot for commit 1b62c0e. This will update automatically on new commits. Configure here.