apollo_dashboard: rename state sync stuck long time alert #12430
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Itay-Tsabary-Starkware
force-pushed
the
02-09-apollo_dashboard_rename_state_sync_stuck_long_time_alert
branch
from
3f99637 to
3f85fd0
Compare
Itay-Tsabary-Starkware
force-pushed
the
02-08-apollo_dashboard_remove_duplicated_per-env_dashboard_files
branch
from
09444c4 to
0c00495
Compare
yonatanw-starkware
left a comment
yonatanw-starkware
left a comment
There was a problem hiding this comment.
@yonatanw-starkware reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).
Itay-Tsabary-Starkware
changed the base branch from
02-08-apollo_dashboard_remove_duplicated_per-env_dashboard_files
to
main-v0.14.1-committer
Itay-Tsabary-Starkware
force-pushed
the
02-09-apollo_dashboard_rename_state_sync_stuck_long_time_alert
branch
from
3f85fd0 to
8f6de09
Compare
Merge activity
|
yonatanw-starkware
left a comment
yonatanw-starkware
left a comment
There was a problem hiding this comment.
@yonatanw-starkware made 1 comment.
Reviewable status:
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware reviewed 2 files and all commit messages.
Reviewable status:
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status:
idan-starkware
left a comment
idan-starkware
left a comment
There was a problem hiding this comment.
@idan-starkware reviewed 2 files and all commit messages.
Reviewable status:
66c8d98
4 participants
Note
Low Risk
Naming/title changes only; alert expressions and thresholds are unchanged, with the main risk being minor dashboard/alert identifier mismatches if any external tooling depends on the previous titles.
Overview
Renames the state sync “stuck” alerts to use title-cased, more descriptive names, specifically distinguishing the long-duration variant as “State Sync Stuck Long Time”.
Updates
get_state_sync_stuck_vec()to pass human-readable titles while deriving the underlying alertnameby lowercasing and underscore-normalizing the title, and aligns the dev Grafana alert JSON titles accordingly.Written by Cursor Bugbot for commit 8f6de09. This will update automatically on new commits. Configure here.