apollo_dashboard: remove duplicated per-env dashboard files #12373
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Itay-Tsabary-Starkware
force-pushed
the
02-08-apollo_dashboard_remove_duplicated_per-env_dashboard_files
branch
from
bbdb07f to
09444c4
Compare
Itay-Tsabary-Starkware
force-pushed
the
02-08-apollo_dashboard_remove_duplicated_per-env_dashboard_files
branch
from
09444c4 to
0c00495
Compare
yonatanw-starkware
left a comment
yonatanw-starkware
left a comment
There was a problem hiding this comment.
@yonatanw-starkware partially reviewed 1 file.
Reviewable status: 1 of 25 files reviewed, all discussions resolved.
|
Artifacts upload workflows: |
yonatanw-starkware
left a comment
yonatanw-starkware
left a comment
There was a problem hiding this comment.
@yonatanw-starkware reviewed 1 file.
Reviewable status: 2 of 25 files reviewed, all discussions resolved.
idan-starkware
left a comment
idan-starkware
left a comment
There was a problem hiding this comment.
@idan-starkware partially reviewed 25 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware partially reviewed 25 files and all commit messages.
Reviewable status:
fde6c98
4 participants
Note
Medium Risk
Medium risk because it changes how alert rules are selected and loaded across environments and removes env-based routing/labels, which could alter which alerts get deployed or their severities if assumptions in tooling/deploy scripts were relying on per-env files.
Overview
Simplifies dashboard alert generation by removing per-environment alert variants (
*_mainnet.json/*_testnet.json) and theAlertEnvFilteringmechanism, leaving a singledev_grafana_alerts.jsonoutput path andAlerts::new(alerts)construction.Updates the Rust generator/tests and local deployment scripts to reference the unified alerts file, and simplifies the monitoring Python builders/CLI by dropping env-based filename resolution and related alert labels/parameters. Also removes unused
strumdependencies and adjusts several alert severities/thresholds in the generateddev_grafana_alerts.json.Written by Cursor Bugbot for commit 0c00495. This will update automatically on new commits. Configure here.