Update to HAML 6 #1426
Merged
Update to HAML 6 #1426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Code changes look like they simplify for the reader. |
deivid-rodriguez
force-pushed
the
haml-6
branch
from
de3ceee to
0edca80
Compare
tnir
reviewed
Jan 15, 2025
Collaborator
tnir
left a comment
tnir
left a comment
There was a problem hiding this comment.
@deivid-rodriguez Thanks for following my progress.
While I am not able check all pages today, there is a small regression at the top page as below:
- Source
Line 10 in cf57e55
deivid-rodriguez
force-pushed
the
haml-6
branch
from
0edca80 to
95c8476
Compare
Contributor
Author
|
Fixed, thank you! |
Analogous to the blog header one.
There were two issues: * Pages using the two column layout were duplicating content. I identified the issue as related to the weird usage of `content_for` inside `wrap_layout`. I removed that because it was also making the template structure harder to follow. * Sometimes HTML entities were not being properly interpreted. Fixed by switching to use `!=` in those cases. Signed-off-by: Takuya Noguchi <[email protected]>
deivid-rodriguez
force-pushed
the
haml-6
branch
from
95c8476 to
e542c19
Compare
Contributor
Author
|
I'll merge now, we can address anything else as follow ups! |
Collaborator
|
@deivid-rodriguez Thanks for finishing up! |
Contributor
Author
|
@tnir Thanks for getting this started! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was none. I just wanted to finish the upgrade of all our stack to latest versions.
What is your fix for the problem, implemented in this PR?
My fix is to upgrade HAML and take care of a couple of problems that showed up.
Supersedes #918.