haml 6.0.0.beta.2 does not work with middleman even 5.x #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
temporarily deployed
to
bundler-site-haml-6-0-0-crsbvu
tnir
added
architecture/maintenance
tnir
force-pushed
the
haml-6.0.0.beta.2
branch
from
aab6bb8 to
8f20718
Compare
Collaborator
Author
|
We should go with #928 instead of this PR 😁 |
Signed-off-by: Takuya Noguchi <[email protected]>
tnir
force-pushed
the
haml-6.0.0.beta.2
branch
from
8f20718 to
5604d8d
Compare
Member
|
@tnir Yeah, your HAML victory should be celebrated by you closing this PR! Awesome work. |
Merged
Contributor
|
I finished migration to HAML 6 over at #1426, closing in favor of that PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAML 6.x (at least haml 6.0.0.beta.2 or haml 6.0.1) does not work with middleman even 5.x (unreleased) since middleman-syntax latest (3.3.0) does not support haml 6.x (see middleman/middleman-syntax#80).
Refs.