Skip to content

Fix several issues with edition links #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deivid-rodriguez merged 4 commits into from
Jan 20, 2025
Merged

Fix several issues with edition links #1432

deivid-rodriguez merged 4 commits into from
Jan 20, 2025

Conversation

@deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Jan 17, 2025 •
edited
Loading

What was the end-user problem that led to this PR?

The problem was that I found several issues with the "Edit this page" links, namely:

What is your fix for the problem, implemented in this PR?

  • Fix for first issue is to use != haml syntax.
  • For the second and third issues, make sure to build links pointing to the new location in rubygems/rubygems.

@deivid-rodriguez deivid-rodriguez merged commit fc60c87 into master Jan 20, 2025
3 checks passed
@deivid-rodriguez deivid-rodriguez deleted the fix-edition-links branch January 20, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@deivid-rodriguez