Skip to content

remove obsolete stm32l1 targets#158

Merged
julianuziemblo merged 1 commit intomasterfrom
julianuziemblo/remove-stm32l1
Nov 19, 2025
Merged

remove obsolete stm32l1 targets#158
julianuziemblo merged 1 commit intomasterfrom
julianuziemblo/remove-stm32l1

Conversation

@julianuziemblo
Copy link
Contributor

@julianuziemblo julianuziemblo commented Nov 18, 2025

Description

related:

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes) - stm32l1 was not supported anyway - this PR just removes the last remaining mention of it

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@gemini-code-assist
Copy link

Summary of Changes

Hello @julianuziemblo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a maintenance chore to clean up the project's build system. It removes obsolete Makefile configurations related to the stm32l1 target, which is no longer supported. This change simplifies the project structure by eliminating dead code and ensures that only relevant build targets are maintained.

Highlights

  • Obsolete Target Removal: Removed all remaining build configurations and references for the stm32l1 microcontroller family, as it is no longer supported.
  • Codebase Cleanup: Streamlined the project by eliminating unused Makefile entries, contributing to a cleaner and more maintainable codebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes obsolete target configuration files for stm32l152xd and stm32l152xe. The changes are straightforward and correctly remove the unsupported targets from the build system as part of a cleanup effort. The changes look correct and the PR is ready to be merged.

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Unit Test Results

9 462 tests  +1 261   8 873 ✅ +1 196   50m 47s ⏱️ + 9m 23s
  561 suites +   82     589 💤 +   65 
    1 files   ±    0       0 ❌ ±    0 

Results for commit 003d21e. ± Comparison against base commit 7c0791e.

This pull request removes 207 and adds 1468 tests. Note that renamed tests count towards both.
phoenix-rtos-tests/libc/math ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/math.math_abs.fabs_special_cond
phoenix-rtos-tests/libc/math ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/math.math_exp.exp_special_cond
phoenix-rtos-tests/libc/math ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/math.math_exp.frexp_special_cond
phoenix-rtos-tests/libc/math ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/math.math_exp.ldexp_special_cond
phoenix-rtos-tests/libc/math ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/math.math_exp.log10_special_cond
phoenix-rtos-tests/libc/math ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/math.math_exp.log2_special_cond
phoenix-rtos-tests/libc/math ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/math.math_exp.log_special_cond
phoenix-rtos-tests/libc/math ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/math.math_frac.ceil_special_cond
phoenix-rtos-tests/libc/math ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/math.math_frac.floor_special_cond
phoenix-rtos-tests/libc/math ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/math.math_frac.fmod_special_cond
…
flash ‑ aarch64a53-zynqmp-qemu:flash
flash ‑ armv7r5f-zynqmp-qemu:flash
phoenix-rtos-tests/cpp/hello-cpp ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/cpp/hello-cpp
phoenix-rtos-tests/initfini/main ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/initfini/main
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_in
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_in_big
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout_big
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_out
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_out_big
…

♻️ This comment has been updated with latest results.

@julianuziemblo julianuziemblo merged commit 3840bae into master Nov 19, 2025
41 checks passed
@julianuziemblo julianuziemblo deleted the julianuziemblo/remove-stm32l1 branch November 19, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments