_targets: remove obsolete stm32l1 target#249
Conversation
JIRA: RTOS-1181
Summary of ChangesHello @julianuziemblo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a maintenance task to clean up the project's build configurations. It removes all traces of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly removes obsolete target configuration files for stm32l1. The deletion of _targets/Makefile.armv7m3-stm32l152xd and _targets/Makefile.armv7m3-stm32l152xe aligns with the stated goal of cleaning up unsupported targets. The change is a straightforward and beneficial cleanup of the build configuration. There are no issues with this change.
Unit Test Results9 462 tests +1 261 8 873 ✅ +1 196 50m 41s ⏱️ + 8m 52s Results for commit f41a18f. ± Comparison against base commit 728bc94. This pull request removes 207 and adds 1468 tests. Note that renamed tests count towards both. |
JIRA: RTOS-1181
Description
related:
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment