Skip to content

remove obsolete stm32l1 target's drivers#605

Merged
julianuziemblo merged 2 commits intomasterfrom
julianuziemblo/remove-stm32l1
Nov 19, 2025
Merged

remove obsolete stm32l1 target's drivers#605
julianuziemblo merged 2 commits intomasterfrom
julianuziemblo/remove-stm32l1

Conversation

@julianuziemblo
Copy link
Contributor

@julianuziemblo julianuziemblo commented Nov 18, 2025

Description

related:

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes) - stm32l1 was not supported anyway - this PR just removes the last remaining mention of its

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@gemini-code-assist
Copy link

Summary of Changes

Hello @julianuziemblo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant cleanup by removing all obsolete and unsupported drivers for the STM32L1 microcontroller family. This action streamlines the project's codebase, reducing maintenance overhead and ensuring that only relevant hardware-specific components are present. Additionally, a minor documentation update was made to accurately reflect the supported STM32L4 series.

Highlights

  • Removal of Obsolete Drivers: All driver files and build configurations specifically for the STM32L1 microcontroller family have been completely removed from the codebase. This includes ADC, DMA, EXTI, Flash, GPIO, I2C, LCD, RCC, RTC, SPI, and UART drivers, along with their associated Makefiles and documentation.
  • Documentation Cleanup: The README file for the STM32L4 multi-driver has been updated to correctly reflect the supported microcontroller family, changing the mention from STM32L152 to STM32L4x6.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great cleanup effort, removing a large number of obsolete files related to the stm32l1 target. This significantly improves the maintainability of the project. I've also noticed a small correction in the README.md for the stm32l4-multi driver and have provided a suggestion to fix a couple of typos in that file.

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Unit Test Results

9 462 tests  +16   8 873 ✅ +16   49m 17s ⏱️ - 2m 49s
  561 suites +16     589 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit aa530b6. ± Comparison against base commit 4615adf.

♻️ This comment has been updated with latest results.

@julianuziemblo julianuziemblo merged commit 74c5e16 into master Nov 19, 2025
41 checks passed
@julianuziemblo julianuziemblo deleted the julianuziemblo/remove-stm32l1 branch November 19, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments