fix: create fresh Server per request in auth test helpers #141
+61
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auth test server helper and no-dns-rebinding-protection example reused a single Server instance across requests, calling connect() on each new transport. SDK v1.26.0's security fix (GHSA-345p-7cg4-v4c7) now throws "Already connected to a transport" in this case. Fix by wrapping Server creation in a factory function called per request, matching the pattern already used by tools_call.ts and everything-server.ts. Also updates no-dns-rebinding-protection.ts to use registerTool() instead of the deprecated tool() API. Co-Authored-By: Claude Opus 4.6 <[email protected]>
commit: |
6 tasks
pcarleton
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes auth test server and no-dns-rebinding-protection example reusing a single Server instance across requests, which breaks with SDK v1.26.0's security fix (GHSA-345p-7cg4-v4c7).
Motivation and Context
SDK v1.26.0 added a runtime guard that throws "Already connected to a transport" when
Protocol.connect()is called on an already-connected server. The auth test helper (createServer.ts) and theno-dns-rebinding-protection.tsexample both created a singleServer/McpServerat module scope and calledconnect()per request, triggering this guard.How Has This Been Tested?
Ran the v1.x client conformance tests with this fix installed locally —
tools_callscenario now passes (was failing with "Already connected" error).Breaking Changes
None — internal test infrastructure only.
Types of changes
Checklist