Promote GiuseppeTT to approver and remove the reviewers section#1122
Promote GiuseppeTT to approver and remove the reviewers section#1122k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
|
/hold +1000 on this! Thank you for your work on this. Waiting for approvals from @ahg-g and @andreyvelich and then we can remove the hold. |
andreyvelich
left a comment
There was a problem hiding this comment.
Thank you so much for all of your great work @GiuseppeTT 🎉
I fully support this, and I'm looking forward to continue driving momentum around JobSet!
/lgtm
|
I'm not the owner of this repository, but I'd like to express my appreciation to @GiuseppeTT and agree to this promotion. Thank you, @GiuseppeTT! |
|
/approve Thanks for the great work on in-place restart and the active engagement generally! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, GiuseppeTT The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest This seems like the flake of #1119 (comment) |
|
@kannon92 I believe the hold can be removed now : ) |
|
/hold cancel All approvers (minus Daniel) have approved so I think this is good to merge. |
|
/cherry-pick release-0.10 |
|
@kannon92: new pull request created: #1124 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kannon92: new pull request created: #1125 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR nominates myself (@GiuseppeTT) as an approver for JobSet.
I have been a reviewer for JobSet for almost 6 months. I have been actively contributing to the project by participating in discussions, reviewing PRs, authoring features and owning releases.
Following the Approver Requirements:
Additionally, I recently authored the complex feature in-place restart:
InPlaceRestartfeature gate as alpha #1096Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I plan to add Andrey and I as approvers to the test infra of JobSet https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/jobset/OWNERS in a follow up PR.
I also plan to move Daniel to
emeritus_approversin a follow up PR.Does this PR introduce a user-facing change?