DateBox, DateRangeBox: Remove skipped tests #32275
Merged
+0
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes previously skipped tests in DateBox and DateRangeBox test suites by correcting test logic and expectations to match actual component behavior.
Changes:
- Fixed DateBox test for calendar cell selection using Enter key by correcting event target expectation
- Updated three DateRangeBox validation tests to properly use
validator.validate()instead of keyboard-based external validation - Adjusted validation error expectations to match actual behavior where external validation replaces internal validation errors
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js | Unskipped and fixed test for Enter key press on calendar - corrected event target from calendar cell to input element |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js | Unskipped three validation tests and updated them to use direct validator.validate() calls, adjusted error count expectations from 2 to 1 to reflect that external validation replaces rather than accumulates with internal validation errors |
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js
Outdated
Show resolved
Hide resolved
marker-dao
previously approved these changes
Jan 22, 2026
r-farkhutdinov
force-pushed
the
26_1_date_box_unskip_tests
branch
from
220367d to
4d41e7d
Compare
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js
Outdated
Show resolved
Hide resolved
r-farkhutdinov
force-pushed
the
26_1_date_box_unskip_tests
branch
from
4d41e7d to
fd16fcf
Compare
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js
Show resolved
Hide resolved
r-farkhutdinov
force-pushed
the
26_1_date_box_unskip_tests
branch
from
0d0eb00 to
3a5684c
Compare
r-farkhutdinov
changed the title
marker-dao
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.