Skip to content

Commit 220367d

Browse files
author
Ruslan Farkhutdinov
committed
DateRangeBox: Remove skipped tests
1 parent 4ee847c commit 220367d

File tree

2 files changed

+1
-84
lines changed

2 files changed

+1
-84
lines changed

packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js

Lines changed: 0 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -2329,35 +2329,6 @@ QUnit.module('Validation', {
23292329
this.raiseExternalValidation(keyboard);
23302330
});
23312331

2332-
QUnit.test('should be raised only once on external validation fail after internal validation fail', function(assert) {
2333-
assert.expect(3);
2334-
2335-
const $startDateBoxInput = $(getStartDateBoxInstance(this.instance).field());
2336-
const keyboard = keyboardMock($startDateBoxInput);
2337-
2338-
this.failInternalValidation(keyboard);
2339-
2340-
this.instance.option({
2341-
onOptionChanged: ({ name, previousValue, value }) => {
2342-
if(name === 'validationErrors') {
2343-
assert.deepEqual(previousValue, [{ message: 'Start value must be a date' }], 'validationErrors previousValue');
2344-
assert.strictEqual(value.length, 1, 'validationErrors length');
2345-
assert.ok(value.some(e => e.message === 'external error'), 'external error exists');
2346-
}
2347-
}
2348-
});
2349-
2350-
const validator = this.$element.dxValidator({
2351-
validationRules: [{
2352-
type: 'custom',
2353-
validationCallback: () => false,
2354-
message: 'external error'
2355-
}]
2356-
}).dxValidator('instance');
2357-
2358-
validator.validate();
2359-
});
2360-
23612332
QUnit.test('should be raised only once on internal validation fail after external validation fail', function(assert) {
23622333
assert.expect(4);
23632334

@@ -2568,60 +2539,6 @@ QUnit.module('Validation', {
25682539
this.raiseExternalValidation(keyboard);
25692540
});
25702541

2571-
QUnit.test('should not be raised on external validation fail after internal validation fail', function(assert) {
2572-
assert.expect(0);
2573-
2574-
const $startDateBoxInput = $(getStartDateBoxInstance(this.instance).field());
2575-
const keyboard = keyboardMock($startDateBoxInput);
2576-
2577-
this.failInternalValidation(keyboard);
2578-
2579-
this.instance.option({
2580-
onOptionChanged: ({ name }) => {
2581-
if(name === 'isValid') {
2582-
assert.ok(false, 'should not be fired');
2583-
}
2584-
}
2585-
});
2586-
2587-
const validator = this.$element.dxValidator({
2588-
validationRules: [{
2589-
type: 'custom',
2590-
validationCallback: () => false,
2591-
message: 'external error'
2592-
}]
2593-
}).dxValidator('instance');
2594-
2595-
validator.validate();
2596-
});
2597-
2598-
QUnit.test('should not be raised on internal validation fail after external validation fail', function(assert) {
2599-
assert.expect(0);
2600-
2601-
const $startDateBoxInput = $(getStartDateBoxInstance(this.instance).field());
2602-
const keyboard = keyboardMock($startDateBoxInput);
2603-
2604-
2605-
this.$element.dxValidator({
2606-
validationRules: [{
2607-
type: 'custom',
2608-
validationCallback: () => false,
2609-
message: 'external error'
2610-
}]
2611-
});
2612-
this.raiseExternalValidation(keyboard);
2613-
2614-
this.instance.option({
2615-
onOptionChanged: ({ name }) => {
2616-
if(name === 'isValid') {
2617-
assert.ok(false, 'should not be fired');
2618-
}
2619-
}
2620-
});
2621-
2622-
this.failInternalValidation(keyboard);
2623-
});
2624-
26252542
QUnit.test('should be raised only once on internal validation success after fail', function(assert) {
26262543
assert.expect(2);
26272544

packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3084,7 +3084,7 @@ QUnit.module('valueChanged handler should receive correct event', {
30843084

30853085
const callCount = this.valueChangedHandler.callCount;
30863086
const event = this.valueChangedHandler.getCall(callCount - 1).args[0].event;
3087-
assert.strictEqual(event, undefined, 'event is undefined');
3087+
assert.strictEqual(event === undefined, true, 'event is undefined');
30883088
};
30893089
this.reinit = (options) => {
30903090
this.instance.dispose();

0 commit comments

Comments
 (0)