Skip to content

Commit 68899e6

Browse files
r-farkhutdinovRuslan Farkhutdinov
andauthored
DateBox, DateRangeBox: Remove skipped tests (#32275)
Co-authored-by: Ruslan Farkhutdinov <ruslan.farkhutdinov@devexpress.com>
1 parent 48c60bd commit 68899e6

File tree

2 files changed

+0
-97
lines changed

2 files changed

+0
-97
lines changed

packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js

Lines changed: 0 additions & 87 deletions
Original file line numberDiff line numberDiff line change
@@ -2329,35 +2329,6 @@ QUnit.module('Validation', {
23292329
this.raiseExternalValidation(keyboard);
23302330
});
23312331

2332-
QUnit.skip('should be raised only once on external validation fail after internal validation fail', function(assert) {
2333-
assert.expect(3);
2334-
2335-
const $startDateBoxInput = $(getStartDateBoxInstance(this.instance).field());
2336-
const keyboard = keyboardMock($startDateBoxInput);
2337-
2338-
this.failInternalValidation(keyboard);
2339-
2340-
this.instance.option({
2341-
onOptionChanged: ({ name, previousValue, value }) => {
2342-
if(name === 'validationErrors') {
2343-
assert.deepEqual(previousValue, [{ message: 'Start value must be a date' }], 'validationErrors previousValue');
2344-
assert.strictEqual(value.length, 2, 'validationErrors length');
2345-
assert.strictEqual(value[1].message, 'external error', 'message');
2346-
}
2347-
}
2348-
});
2349-
2350-
this.$element.dxValidator({
2351-
validationRules: [{
2352-
type: 'custom',
2353-
validationCallback: () => false,
2354-
message: 'external error'
2355-
}]
2356-
});
2357-
2358-
this.raiseExternalValidation(keyboard);
2359-
});
2360-
23612332
QUnit.test('should be raised only once on internal validation fail after external validation fail', function(assert) {
23622333
assert.expect(4);
23632334

@@ -2492,37 +2463,6 @@ QUnit.module('Validation', {
24922463
const endDateBoxKeyboard = keyboardMock($endDateBoxInput);
24932464
this.failInternalValidation(endDateBoxKeyboard);
24942465
});
2495-
2496-
QUnit.skip('should be raised only once on external validation fail if other internal validation is already failed', function(assert) {
2497-
assert.expect(4);
2498-
2499-
this.$element.dxValidator({
2500-
validationRules: [{
2501-
type: 'custom',
2502-
validationCallback: () => false,
2503-
message: 'external error'
2504-
}]
2505-
});
2506-
2507-
const $startDateBoxInput = $(getStartDateBoxInstance(this.instance).field());
2508-
const startDateBoxKeyboard = keyboardMock($startDateBoxInput);
2509-
this.failInternalValidation(startDateBoxKeyboard);
2510-
2511-
this.instance.option({
2512-
onOptionChanged: ({ name, previousValue, value }) => {
2513-
if(name === 'validationErrors') {
2514-
assert.strictEqual(previousValue.length, 1, 'previousValue length');
2515-
assert.strictEqual(previousValue[0].message, 'Start value must be a date', 'previousValue[0] message');
2516-
assert.strictEqual(value.length, 2, 'value length');
2517-
assert.deepEqual(value[1].message, 'external error', 'value[1]');
2518-
}
2519-
}
2520-
});
2521-
2522-
const $endDateBoxInput = $(getEndDateBoxInstance(this.instance).field());
2523-
const endDateBoxKeyboard = keyboardMock($endDateBoxInput);
2524-
this.raiseExternalValidation(endDateBoxKeyboard);
2525-
});
25262466
});
25272467

25282468
QUnit.module('isValid option change', () => {
@@ -2570,33 +2510,6 @@ QUnit.module('Validation', {
25702510
this.raiseExternalValidation(keyboard);
25712511
});
25722512

2573-
QUnit.skip('should not be raised on external validation fail after internal validation fail', function(assert) {
2574-
assert.expect(0);
2575-
2576-
const $startDateBoxInput = $(getStartDateBoxInstance(this.instance).field());
2577-
const keyboard = keyboardMock($startDateBoxInput);
2578-
2579-
this.failInternalValidation(keyboard);
2580-
2581-
this.instance.option({
2582-
onOptionChanged: ({ name }) => {
2583-
if(name === 'isValid') {
2584-
assert.ok(false, 'should not be fired');
2585-
}
2586-
}
2587-
});
2588-
2589-
this.$element.dxValidator({
2590-
validationRules: [{
2591-
type: 'custom',
2592-
validationCallback: () => false,
2593-
message: 'external error'
2594-
}]
2595-
});
2596-
2597-
this.raiseExternalValidation(keyboard);
2598-
});
2599-
26002513
QUnit.test('should not be raised on internal validation fail after external validation fail', function(assert) {
26012514
assert.expect(0);
26022515

packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3145,16 +3145,6 @@ QUnit.module('valueChanged handler should receive correct event', {
31453145
this.checkEvent(assert, 'keydown', this.$input, 'enter');
31463146
this.testProgramChange(assert);
31473147
});
3148-
3149-
QUnit.skip(`on calendar cell selecting using enter when useMaskBehavior=${useMaskBehavior}`, function(assert) {
3150-
this.reinit({ useMaskBehavior });
3151-
const $calendarCell = $('.dx-calendar-today');
3152-
3153-
this.keyboard.press('enter');
3154-
3155-
this.checkEvent(assert, 'keydown', $calendarCell, 'enter');
3156-
this.testProgramChange(assert);
3157-
});
31583148
});
31593149

31603150
['calendar', 'rollers'].forEach(pickerType => {

0 commit comments

Comments
 (0)