⚡ Optimize SettingService database query with caching

app/Services/SettingService.php

@@ -5,15 +5,18 @@
 namespace App\Services;
 
 use App\Models\Setting;
+use Illuminate\Support\Facades\Cache;
 
 class SettingService
 {
     public static function isRegisterAllowed(): bool
     {
-        $isRegisterAllow = Setting::query()
-            ->where('key', 'allow_register')
-            ->first()
-            ->value;
+        $isRegisterAllow = Cache::remember('setting:allow_register', 3600, function () {
+            return Setting::query()
+                ->where('key', 'allow_register')
+                ->first()
+                ->value;
+        });
 
         return filter_var($isRegisterAllow, FILTER_VALIDATE_BOOLEAN);
     }

tests/Feature/Auth/RegistrationTest.php

@@ -2,14 +2,24 @@
 
 use App\Models\Setting;
 use App\Models\User;
+use Illuminate\Support\Facades\Cache;
+use Illuminate\Support\Facades\Http;
 
 use function Pest\Laravel\get;
 
 beforeEach(function () {
+    Http::fake([
+        'https://challenges.cloudflare.com/turnstile/v0/siteverify' => Http::response([
+            'success' => true,
+        ]),
+    ]);
+
     Setting::query()
         ->where('key', 'allow_register')
         ->firstOrFail()
         ->update(['value' => true]);
+
+    Cache::forget('setting:allow_register');
 });
 
 test('registration screen can be rendered', function () {
@@ -214,6 +224,8 @@
         ->firstOrFail()
         ->update(['value' => false]);
 
+    Cache::forget('setting:allow_register');
+
     get(route('register'))->assertStatus(503);
 });
 
@@ -223,5 +235,7 @@
         ->firstOrFail()
         ->update(['value' => false]);
 
+    Cache::forget('setting:allow_register');
+
     Livewire::test('layouts.header')->assertDontSeeText('註冊');
 });