β‘ Optimize SettingService database query with caching #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What:
Optimized
SettingService::isRegisterAllowedby caching the database query result usingCache::remember. The cache key issetting:allow_registerwith a TTL of 1 hour (3600 seconds).π― Why:
To prevent hitting the database on every request to check if registration is allowed, which improves performance and reduces database load.
π Measured Improvement:
Benchmark showed a significant reduction in execution time and database queries:
Also updated tests to handle cache invalidation and mock external Captcha requests to ensure test suite passes reliably.
PR created automatically by Jules for task 2240378745323387921 started by @yilanboy