-
-
Notifications
You must be signed in to change notification settings - Fork 5
fix: typo in cfetch.mdx & buildkit.mdx
#211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo in cfetch.mdx & buildkit.mdx
#211
Conversation
📝 WalkthroughWalkthroughTwo documentation files updated: buildkit.mdx receives minor formatting adjustments, while cfetch.mdx updates example usage and changes the CFetchConfig interface signature from optional fields to required fields (ttl, tags, key, verbose), representing a breaking API change. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌑 This pull request will not trigger status changes. Learn moreLunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: You can change this by either removing the keyword above from the PR's title, or modifying the Tracked FilesNote The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.
Warnings reference
|
…tch` (#207) * i18n(fr): add `ecosystem/packages/buildkit` & `ecosystem/packages/cfetch` See #194 * Apply suggestions coderabbit suggestions (changes from #211) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: paul valladares <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
This was reported in #207 so instead of telling coderabbit this has nothing to do with the translation, this is probably better to fix this. 😄
buildkit.mdx:esBuildis not the right casing foresbuildcfetch.mdx: a code snippet uses Typescript optional properties syntax for an example usage which seems wrongSummary by CodeRabbit
Documentation
Updates
✏️ Tip: You can customize this high-level summary in your review settings.