Skip to content

Conversation

@ArmandPhilippot
Copy link
Member

@ArmandPhilippot ArmandPhilippot commented Jan 24, 2026

Description

Adds the French translations of ecosystem/packages/buildkit.mdx & ecosystem/packages/cfetch.mdx added in #194

Summary by CodeRabbit

  • Documentation
    • Added French documentation for the Buildkit package, covering installation, usage examples, CLI commands and flags, and resource handling notes.
    • Added French documentation for the cfetch integration, including prerequisites, installation steps, usage examples, and API/reference guidance.

✏️ Tip: You can customize this high-level summary in your review settings.

@ArmandPhilippot ArmandPhilippot requested a review from a team as a code owner January 24, 2026 13:12
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2026

📝 Walkthrough

Walkthrough

Two new French documentation pages were added for Astro ecosystem packages: @withstudiocms/buildkit and @studiocms/cfetch, covering installation, usage, CLI options, and API examples in French.

Changes

Cohort / File(s) Summary
French docs — Buildkit & CFetch
src/content/docs/fr/ecosystem/packages/buildkit.mdx, src/content/docs/fr/ecosystem/packages/cfetch.mdx
Added two French documentation pages. buildkit.mdx documents CLI usage, install steps, flags, and file-copy rules. cfetch.mdx documents integration usage, prerequisites, installation, API surface, and TypeScript examples. Documentation-only changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • dreyfus92
  • Adammatthiesen

Poem

🐰 Je sautille, carnet en main, sous la pluie fine,

Deux pages en français pour guider vos racines.
Buildkit construit, cfetch va chercher,
Ensemble ils aident votre code à briller. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding French translations (i18n) of two ecosystem package documentation files (buildkit and cfetch).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@studiocms-no-reply
Copy link
Member

studiocms-no-reply commented Jan 24, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/ecosystem/packages/buildkit.mdx Localization added, will be marked as complete.
fr/ecosystem/packages/cfetch.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Fix all issues with AI agents
In `@src/content/docs/fr/ecosystem/packages/buildkit.mdx`:
- Line 66: Replace the incorrect casing "esBuild" with the official lowercase
"esbuild" in the document text and link label (the string currently reading "la
documentation d'esBuild") so the visible link text and any occurrences of
"esBuild" use "esbuild" for consistency with upstream documentation.

In `@src/content/docs/fr/ecosystem/packages/cfetch.mdx`:
- Around line 119-124: The example object literal uses TypeScript type syntax
(ttl?:, tags?:, key?:, verbose?:) which is invalid at runtime; replace these
type-like entries with actual property assignments (e.g., use ttl:
Duration.hours(1), tags: ['example'], key: "api-data-fetch", verbose: false) so
the example is a valid object literal; update the example where the object
containing ttl, tags, key, and verbose is shown and ensure Duration.hours(1)
remains a call expression rather than a type.
- Around line 21-24: The cFetchEffect example in the object literal uses
TypeScript interface-style optional property syntax (e.g., ttl?: ..., tags?:
...) which is invalid in object literals; update the examples in both the French
file (src/content/docs/fr/ecosystem/packages/cfetch.mdx) and the English
counterpart to use normal object property syntax (ttl: Duration.hours(1), tags:
['example'], key: "api-data-fetch", verbose: false) within the cFetchEffect
usage and any other examples referencing Duration.hours or the same options
object so the object literal is valid JavaScript/TypeScript.
🧹 Nitpick comments (1)
src/content/docs/fr/ecosystem/packages/cfetch.mdx (1)

112-118: Localize example identifiers for French readers.

These are pedagogical snippets; consider French identifiers (e.g., donnees, reponse) to match established repo practice and improve readability.

Based on learnings, localize identifiers in French examples.

)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@ArmandPhilippot ArmandPhilippot marked this pull request as draft January 24, 2026 20:59
@ArmandPhilippot ArmandPhilippot marked this pull request as ready for review January 24, 2026 21:06
@dreyfus92 dreyfus92 merged commit eca5dcb into withstudiocms:main Jan 24, 2026
9 checks passed
@ArmandPhilippot ArmandPhilippot deleted the i18n/fr-add-ecosystem/packages/buildkit-cfetch branch January 24, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants