-
-
Notifications
You must be signed in to change notification settings - Fork 5
i18n(fr): add ecosystem/packages/buildkit & ecosystem/packages/cfetch
#207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(fr): add ecosystem/packages/buildkit & ecosystem/packages/cfetch
#207
Conversation
📝 WalkthroughWalkthroughTwo new French documentation pages were added for Astro ecosystem packages: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@src/content/docs/fr/ecosystem/packages/buildkit.mdx`:
- Line 66: Replace the incorrect casing "esBuild" with the official lowercase
"esbuild" in the document text and link label (the string currently reading "la
documentation d'esBuild") so the visible link text and any occurrences of
"esBuild" use "esbuild" for consistency with upstream documentation.
In `@src/content/docs/fr/ecosystem/packages/cfetch.mdx`:
- Around line 119-124: The example object literal uses TypeScript type syntax
(ttl?:, tags?:, key?:, verbose?:) which is invalid at runtime; replace these
type-like entries with actual property assignments (e.g., use ttl:
Duration.hours(1), tags: ['example'], key: "api-data-fetch", verbose: false) so
the example is a valid object literal; update the example where the object
containing ttl, tags, key, and verbose is shown and ensure Duration.hours(1)
remains a call expression rather than a type.
- Around line 21-24: The cFetchEffect example in the object literal uses
TypeScript interface-style optional property syntax (e.g., ttl?: ..., tags?:
...) which is invalid in object literals; update the examples in both the French
file (src/content/docs/fr/ecosystem/packages/cfetch.mdx) and the English
counterpart to use normal object property syntax (ttl: Duration.hours(1), tags:
['example'], key: "api-data-fetch", verbose: false) within the cFetchEffect
usage and any other examples referencing Duration.hours or the same options
object so the object literal is valid JavaScript/TypeScript.
🧹 Nitpick comments (1)
src/content/docs/fr/ecosystem/packages/cfetch.mdx (1)
112-118: Localize example identifiers for French readers.These are pedagogical snippets; consider French identifiers (e.g.,
donnees,reponse) to match established repo practice and improve readability.Based on learnings, localize identifiers in French examples.
Description
Adds the French translations of
ecosystem/packages/buildkit.mdx&ecosystem/packages/cfetch.mdxadded in #194Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.