Skip to content

feat: add branch support to CDN content delivery configs#3466

Draft
dkrizan wants to merge 2 commits intodkrizan/branching-improvementsfrom
dkrizan/cdn-branch-support
Draft

feat: add branch support to CDN content delivery configs#3466
dkrizan wants to merge 2 commits intodkrizan/branching-improvementsfrom
dkrizan/cdn-branch-support

Conversation

@dkrizan
Copy link
Contributor

@dkrizan dkrizan commented Feb 10, 2026

Summary

  • Links CDN configs to branches via a foreign key (branch_id) instead of the plain filterBranch string column
  • Adds branch selector to the CDN config dialog when branching is enabled
  • Shows branch name chip on CDN list items
  • Cleans up CDN configs when a branch is deleted
  • Migrates existing configs to the default branch during branching enablement
  • Feature guard rejects CDN create/update with filterBranch when BRANCHING feature is disabled

Test plan

  • All 12 ContentDeliveryConfigBranchingTest tests pass, including:
    • Create/update CDN config with specific branch
    • Create without branch defaults to default branch
    • Non-existent branch returns 404
    • Delete branch cascades to CDN configs
    • Feature guard rejects create when branching not enabled
    • Feature guard rejects update when branching not enabled

🤖 Generated with Claude Code

CDN configs are now linked to branches via a foreign key instead of a
plain string. When branching is enabled, users can select a branch per
CDN config; the feature guard rejects requests that specify a branch
when the BRANCHING feature is disabled.

- Replace `filterBranch` string column with `branch` FK on ContentDeliveryConfig
- Add branch selector to the CDN dialog in the webapp
- Show branch chip on CDN list items
- Clean up CDN configs when a branch is deleted
- Migrate existing configs to the default branch during branching setup
- Add comprehensive tests including feature-guard coverage

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dkrizan/cdn-branch-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dkrizan dkrizan changed the base branch from main to dkrizan/branching-improvements February 12, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant