Fix Windows file:// URL generation in log viewer #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, normalizePath() returns backslash paths like D:\path\to\logs. The previous code created invalid URLs like file://D:\path\to\logs. Valid Windows file URLs need: - Three slashes before the drive letter: file:///D:/... - Forward slashes in the path Added path_to_file_url() helper that uses winslash="/" and adds the correct number of slashes per platform. Fixes log viewer showing "no logs" on Windows. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Author
|
(Although this may end up causing other viewer problems now that I'm testing more myself. But I do think the issue is Windows file formats) |
The previous commit fixed URL generation but broke loading logs because file:///D:/path was being parsed back to /D:/path (invalid on Windows). Added file_url_to_path() helper that strips the extra leading slash on Windows when converting file:// URLs back to filesystem paths. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Author
|
Possible fix? |
simonpcouch
reviewed
Dec 29, 2025
Collaborator
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
Thanks so much! This seems like a reasonable approach.
I'm currently taking a couple weeks to rest but will come back to this in the New Year. :)
Author
|
Rest is awesome! Hope you have a couple of great holiday weeks. Absolutely no rush on this, only reason I brought this up now is because I'm staying home in some miserable winter weather playing with my extra Claude usage 😅 Happy New Year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, normalizePath() returns backslash paths like D:\path\to\logs. The previous code created invalid URLs like file://D:\path\to\logs.
Claude Opus 4.5 says:
Valid Windows file URLs need:
Added path_to_file_url() helper that uses winslash="/" and adds the correct number of slashes per platform.
Fixes log viewer showing "no logs" on Windows reported in Issue 199
🤖 Code generated in large part by Claude Code