blockifier: compute_proving_gas for cairo_primitives #12469
+20
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2026
|
This change is |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
avivg-starkware
force-pushed
the
avivg/blockifier/compute_proving_gas_for_cairo_primitives
branch
2 times, most recently
from
bf253d4 to
7abd78e
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/cairo_primitives_to_gas
branch
from
ddde9e6 to
2c59ece
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/compute_proving_gas_for_cairo_primitives
branch
from
7abd78e to
8bf6bd2
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/cairo_primitives_to_gas
branch
from
2c59ece to
4a50c7f
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/compute_proving_gas_for_cairo_primitives
branch
2 times, most recently
from
2d7e0f6 to
d6b5bfd
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/cairo_primitives_to_gas
branch
from
4a50c7f to
31ccc82
Compare
avivg-starkware
commented
Feb 10, 2026
Contributor
Author
avivg-starkware
left a comment
avivg-starkware
left a comment
There was a problem hiding this comment.
@avivg-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion.
crates/blockifier/src/bouncer.rs line 900 at r1 (raw file):
// TODO(AvivG): To support opcodes in the computation, os resources should include opcode // counters.
Will happen as part of modifying tx_resources.computation.os_vm_resources
Code quote:
// TODO(AvivG): To support opcodes in the computation, os resources should include opcode
// counters.
avivg-starkware
force-pushed
the
avivg/blockifier/compute_proving_gas_for_cairo_primitives
branch
from
d6b5bfd to
7a891bf
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/cairo_primitives_to_gas
branch
from
31ccc82 to
f0672b5
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/compute_proving_gas_for_cairo_primitives
branch
from
7a891bf to
698ceda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core gas/weight accounting used for block capacity and fee-related limits; mistakes could shift proving-gas totals and affect block admission decisions.
Overview
Updates proving-gas calculation to operate directly on
CairoPrimitiveCounterMaprather than converting from builtin-only counters.In
get_tx_weights, the proving-gas path now builds Cairo-primitive counters from OS VM builtins and merges in the transaction’s Cairo-primitive counters (to avoid double-countingtx_vm_resources), then uses these counters consistently throughcompute_proving_gas/proving_gas_from_cairo_primitives_and_sierra_gas.Written by Cursor Bugbot for commit 698ceda. This will update automatically on new commits. Configure here.