blockifier: enable getting cairo_primitive gas cost by name #12461
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
avivg-starkware
force-pushed
the
avivg/blockifier/get_cairo_primitive_cost
branch
2 times, most recently
from
48bc7b3 to
8469e09
Compare
avivg-starkware
commented
Feb 10, 2026
Contributor
Author
avivg-starkware
left a comment
avivg-starkware
left a comment
There was a problem hiding this comment.
@avivg-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion.
crates/blockifier/src/blockifier_versioned_constants.rs line 950 at r2 (raw file):
impl BuiltinGasCosts { pub fn get_builtin_gas_cost(&self, builtin: &BuiltinName) -> Result<u64, GasCostsError> {
This will be made private, and outer use will only be by fn get_cairo_primitive_gas_cost
(I added TODO in the following PR #12462)
Code quote:
pub fn get_builtin_gas_cost(&self, builtin: &BuiltinName) -> Result<u64, GasCostsError> {
avivg-starkware
force-pushed
the
avivg/blockifier/get_cairo_primitive_cost
branch
from
8469e09 to
be8d717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small, additive API change limited to gas-cost lookup logic; minimal risk unless downstream callers rely on the old builtin-only access pattern.
Overview
Adds support in
BuiltinGasCosts(withinblockifier_versioned_constants.rs) to look up gas costs by aCairoPrimitiveName, unifying builtins and opcode pricing underget_cairo_primitive_gas_cost.Introduces opcode-specific lookup via
get_opcode_gas_cost(currently coveringOpcodeName::Blake) and wires in the required imports; no gas values change, only how callers can access them.Written by Cursor Bugbot for commit be8d717. This will update automatically on new commits. Configure here.