Skip to content

Fix nation stats viewer tooltip from only displaying one creator per demon #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stadust merged 2 commits into from
Jan 5, 2025
Merged

Fix nation stats viewer tooltip from only displaying one creator per demon #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d438b06
Fixed created_in from only retrieving one creator per demon
jasonyess Dec 30, 2024
b9b25da
Modify created_in sql query
jasonyess Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pointercrate-demonlist/src/nationality/get.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
}

pub async fn created_in(nation: &Nationality, connection: &mut PgConnection) -> Result<Vec<MiniDemonWithPlayers>> {
let mut stream = sqlx::query!( r#"select distinct on (demon) demon, demons.name::text as "demon_name!", demons.position, players.name::text as "player_name!" from creators inner join demons on demons.id=demon inner join players on players.id=creator where nationality=$1"#, nation.iso_country_code).fetch(connection);
let mut stream = sqlx::query!( r#"select demon, demons.name::text as "demon_name!", demons.position, players.name::text as "player_name!" from creators inner join demons on demons.id=demon inner join players on players.id=creator where nationality=$1 order by demon"#, nation.iso_country_code).fetch(connection);

Check warning on line 153 in pointercrate-demonlist/src/nationality/get.rs

View check run for this annotation

Codecov / codecov/patch

pointercrate-demonlist/src/nationality/get.rs#L153 

Added line #L153 was not covered by tests

let mut creations = Vec::<MiniDemonWithPlayers>::new();

Expand Down
Loading