Skip to content

Conversation

@jasonyess
Copy link
Contributor

@jasonyess jasonyess commented Dec 30, 2024

Fixed the created_in function only retrieving one creator per demon. In the previous SQL statement, every retrieved demon was unique, causing this to happen:
image

Removing the DISTINCT ON statement allowed multiple creators of the same demon to be retrieved:
image

Resolves #178

License Acceptance

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.61%. Comparing base (d0b0dc8) to head (b9b25da).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pointercrate-demonlist/src/nationality/get.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   29.61%   29.61%           
=======================================
  Files         116      116           
  Lines        8314     8314           
=======================================
  Hits         2462     2462           
  Misses       5852     5852           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@stadust stadust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for looking into this. No idea why I put a distinct on here, maybe a copy-paste error? I think it does need an order by as well though:

@stadust stadust merged commit 1b63789 into stadust:master Jan 5, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nations Stats Viewer Tooltip doesn't display everyone on levels in the Created section

2 participants