SIP-040: SIP for improved post-conditions#257
Open
brice-stacks wants to merge 12 commits intostacksgov:mainfrom
Open
SIP-040: SIP for improved post-conditions#257brice-stacks wants to merge 12 commits intostacksgov:mainfrom
brice-stacks wants to merge 12 commits intostacksgov:mainfrom
Conversation
This was referenced Feb 7, 2026
5 tasks
wileyj
reviewed
Feb 11, 2026
Contributor
|
@brice-stacks can you move the files into the expected structure? |
wileyj
changed the title
Co-authored-by: wileyj <2847772+wileyj@users.noreply.github.com>
wileyj
reviewed
Feb 11, 2026
Co-authored-by: wileyj <2847772+wileyj@users.noreply.github.com>
wileyj
reviewed
Feb 11, 2026
wileyj
reviewed
Feb 11, 2026
wileyj
reviewed
Feb 11, 2026
wileyj
reviewed
Feb 11, 2026
wileyj
reviewed
Mar 5, 2026
| very bad habit to teach our users, and we can do better. The concern of the user | ||
| is typically about assets moving out of their own wallet, and they are not | ||
| concerned about assets moving in and out of contracts, triggered by their call. | ||
| Contracts that they do care about should be protected internally, using the |
Contributor
There was a problem hiding this comment.
Suggested change
| Contracts that they do care about should be protected internally, using the | |
| Contracts that users do care about should be protected internally, using the |
wileyj
reviewed
Mar 5, 2026
Comment on lines
+63
to
+64
| reverting to signing `Allow` mode transactions, just to make it work. This is a | ||
| very bad habit to teach our users, and we can do better. The concern of the user |
Contributor
There was a problem hiding this comment.
I still feel this line is very subjective and emotionally driven. what about a change like this:
Suggested change
| reverting to signing `Allow` mode transactions, just to make it work. This is a | |
| very bad habit to teach our users, and we can do better. The concern of the user | |
| reverting to signing `Allow` mode transactions, just to make it work, which erodes the security habits we want users to build. The concern of the user |
Contributor
There was a problem hiding this comment.
I think the original text is a bit finger-pointy, that's why it keeps drawing my attention to it.
wileyj
reviewed
Mar 5, 2026
| These new post-condition additions are backwards compatible for transactions | ||
| that do not use the new mode or condition code. Nodes need to be updated to | ||
| accept transactions with these new features, but existing SIP-005 | ||
| post-conditions will continue to operate as they do now. Pre-upgrade nodes will |
Contributor
There was a problem hiding this comment.
should Pre-upgrade be changed to something like Prior to activation?
wileyj
reviewed
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This SIP proposes two new post-condition improvements,
Originatormode, and aMAY SENDcondition for NFTs.