Skip to content

Conversation

@brice-stacks
Copy link
Contributor

Description

Implements new features in stacksgov/sips#257 for epoch 3.4.

  • Originator mode: deny mode for origin account, allow mode for others
  • MaySend condition code for NFTs: the asset may be sent, but it doesn't have to be

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • For new Clarity features or consensus changes, add property tests (see docs/property-testing.md)
  • Changelog is updated
  • Required documentation changes (e.g., rpc/openapi.yaml for RPC endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

- `Originator` mode: `deny` mode for origin account, `allow` mode for
  others
- `MaySend` condition code for NFTs: the asset may be sent, but it
  doesn't have to be
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 91.79266% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.43%. Comparing base (8a9f3f2) to head (b1af687).

Files with missing lines Patch % Lines
stackslib/src/chainstate/stacks/block.rs 60.00% 30 Missing ⚠️
stackslib/src/chainstate/stacks/db/transactions.rs 98.14% 6 Missing ⚠️
stackslib/src/chainstate/stacks/transaction.rs 96.61% 2 Missing ⚠️

❌ Your project check has failed because the head coverage (68.43%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6885       +/-   ##
============================================
+ Coverage    47.54%   68.43%   +20.89%     
============================================
  Files          597      597               
  Lines       359952   360383      +431     
============================================
+ Hits        171126   246629    +75503     
+ Misses      188826   113754    -75072     
Files with missing lines Coverage Δ
stacks-common/src/types/mod.rs 72.64% <100.00%> (+0.68%) ⬆️
stackslib/src/chainstate/stacks/mod.rs 73.18% <100.00%> (-3.50%) ⬇️
stackslib/src/clarity_vm/clarity.rs 87.11% <100.00%> (+21.30%) ⬆️
stackslib/src/chainstate/stacks/transaction.rs 75.30% <96.61%> (+30.80%) ⬆️
stackslib/src/chainstate/stacks/db/transactions.rs 76.04% <98.14%> (+47.21%) ⬆️
stackslib/src/chainstate/stacks/block.rs 91.10% <60.00%> (+55.75%) ⬆️

... and 471 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a9f3f2...b1af687. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant