Skip to content

Conversation

@sethrj
Copy link
Contributor

@sethrj sethrj commented Jan 5, 2026

This works around an openblas test failure on macos ARM architectures by omitting tests during builds: OpenMathLib/OpenBLAS#5459

@mathomp4
Copy link
Contributor

mathomp4 commented Jan 5, 2026

@sethrj I assume this is independent of #2890 by @wdconinc ?

@sethrj
Copy link
Contributor Author

sethrj commented Jan 5, 2026

@mathomp4 correct; this one only affects the makefile build system.

@rtrigg
Copy link

rtrigg commented Jan 10, 2026

I tried to reproduce this on macOS Sequoia M1 with apple-clang 17.0.0 / gfortran 15.2.0, and [email protected] failed during the build when linking test binaries (dblat1, sblat1) with LTO errors:

ld: -lto_library library filename must be 'libLTO.dylib'
make: *** [Makefile:171: tests] Error 2

So, different error than the cblas_sgemm accuracy failure, but with the PR applied, the build did complete successfully.

albestro
albestro previously approved these changes Jan 16, 2026
Copy link
Contributor

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested, but for what concerns nvpl_blas, it lgtm

Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alalazo alalazo self-assigned this Jan 19, 2026
@sethrj
Copy link
Contributor Author

sethrj commented Jan 19, 2026

@alalazo Indeed I noticed the last set of openblas builds fail as well. Some subtlety of makefiles is causing a race condition in the build (which claims to be parallel-safe) and I'm trying to find away around it. (I don't see the issue on macos.) Giving it another shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants