Skip to content

Commit bac86e4

Browse files
committed
Make shared after building static
1 parent 1b5e55f commit bac86e4

File tree

1 file changed

+11
-6
lines changed
  • repos/spack_repo/builtin/packages/openblas

1 file changed

+11
-6
lines changed

repos/spack_repo/builtin/packages/openblas/package.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -612,10 +612,16 @@ def make_defs(self):
612612

613613
@property
614614
def build_targets(self):
615-
targets = ["libs", "netlib"]
616-
if "+shared" in self.spec:
617-
targets.append("shared")
618-
return ["-s"] + self.make_defs + targets
615+
# Note that building shared simultaneously with libs or netlib seems to
616+
# result in errors, so we postpone that to a "run_after".
617+
# Also because of the verbosity and number of object files created, we
618+
# suppress makefile command echoing via `-s`.
619+
return ["-s"] + self.make_defs + ["libs", "netlib"]
620+
621+
@run_after("build", when="+shared")
622+
def build_shared(self):
623+
tty.info("Building shared libraries")
624+
make("shared", *self.make_defs)
619625

620626
@run_after("build")
621627
@on_package_attributes(run_tests=True)
@@ -624,8 +630,7 @@ def check_build(self):
624630

625631
@property
626632
def install_targets(self):
627-
make_args = [f"PREFIX={self.prefix}", "install"]
628-
return make_args + self.make_defs
633+
return self.make_defs + [f"PREFIX={self.prefix}", "install"]
629634

630635
@run_after("install")
631636
@on_package_attributes(run_tests=True)

0 commit comments

Comments
 (0)