Skip to content

Conversation

@Princess-Cheeseballs
Copy link
Member

@Princess-Cheeseballs Princess-Cheeseballs commented Jan 6, 2026

About the PR

Title. Moved some code around so items spawned in the smart fridge show up as entries, this is useful for smart fridge prototypes which have entities stocked in them by default.
Closes #41758

Why / Balance

Needed downstream, useful upstream.

Technical details

Moved the entry code to a EntInsertedIntoContainer listener.

Media

image

Requirements

Breaking changes

SmartFridgeSystem was split into an abstract SharedSmartFridgeSystem and a client and server side system.
SmartFridgeUISystem was replaced with the client side SmartFridgeSystem.

Changelog

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. labels Jan 6, 2026
@arenaconspiracy
Copy link

closes #41758

@Pok27 Pok27 added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 7, 2026
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, good work with fixing the prediction 🫡

@slarticodefast slarticodefast added this pull request to the merge queue Jan 9, 2026
Merged via the queue into space-wizards:master with commit 8ec4669 Jan 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SmartFridgeSystem does not bind premade container fills to UI entries

5 participants