-
Notifications
You must be signed in to change notification settings - Fork 5k
Expand and fill lathe menu categories #42223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
iaada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had originally did this for several other lathes but never finished the job. Most of this are nitpicks and suggestions, but overall these are good changes.
| lathe-category-parts = Parts | ||
| lathe-category-tools = Tools | ||
| lathe-category-weapons = Weapons | ||
| lathe-category-containers = Containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to be alphabetical.
| - type: latheCategory | ||
| id: Containers | ||
| name: lathe-category-containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too.
| lathe-category-containers = Containers | ||
|
|
||
| # Medical | ||
| lathe-category-topicals = Topicals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer this category to be named "Medicinal" to genericize it a bit and leave room for non-typical treatments, like canes.
| - type: latheCategory | ||
| id: Topicals | ||
| name: lathe-category-topicals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| parent: BaseSurgicalRecipe |
| id: WhiteCane | ||
| result: WhiteCane | ||
| categories: | ||
| - Tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be in the tools category if you think it should, but it should also be added to the "Medicinal" category.
iaada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Categories look good. Should help players find / learn about items in lathes.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
i think i fucked something up while fixing the merge conflict |
668831b to
b503c7f
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
okay the merge worked now, sorry for all the accidental review requests. |
About the PR
Added several items to lathe menu categories and added 2 new categories, Containers and Topicals.
Here's the full list:
Autolathe:
Tools
appraisal tool, utility knife, flashlight, welding mask, spray bottle,
light replacer, holo sign projector, wire brush, mop, flashlight, dropper, syringe
Containers
air tanks, beakers, several mugs and glasses,
pill canister, vial, bucket, trash bag
Clothing
tank harness, warning cone, welding mask
Parts
modular receiver
Protolathe:
Tools
(advanced) mineral scanner, (diamond) mining drill, push horn, QSI, welding gas mask,
advanced mop, mega spray bottle, spray nozzle, desynchronizer, (bluespace/cryo) syringe, dropper
Containers
all beakers, vial, bottle, jug, pill canister
Clothing
all bags of holding, all science boots, welding gas mask,
chemical analysis goggles, backpack water tank
Weapons
syringe gun, mini syringe
Medical techfab:
Tools
implant extractor, defibrillator, canes, (bluespace/cryo) syringe, dropper
Clothes
latex/nitrile gloves, sterile mask, chemical analysis goggles
Topicals
gauze, ointment, bruise packs
Containers
medkits, beakers, bottles, body bag
Why / Balance
This makes it much easier to find certain items if you don't want to type out the name or don't know the exact name. Currently a lot of items are not in the categories they belong (e.g. utility knife or appraisal tool are not under Tools) or the categories are inconsistently filled (e.g. harmpack is in the clothing category but the backpack water tank is not). In addition, the two new categories make it easier to find all the available containers or to print topicals without having to scroll a lot.
Technical details
100% yaml
Media
Requirements
Breaking changes
Changelog
🆑bnuuy