-
Notifications
You must be signed in to change notification settings - Fork 5k
Increase shuttle FTL cooldown to prevent FTL spamming #42209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase shuttle FTL cooldown to prevent FTL spamming #42209
Conversation
Content.Server/Shuttles/Systems/ShuttleSystem.FasterThanLight.cs
Outdated
Show resolved
Hide resolved
|
please read our pull request conventions on changelogs |
Thanks, the changelog has been updated with the ADMIN tag |
beck-thompson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! Thanks for the PR. I'll ask some other people about the cooldown increase
|
looks like people like this! Thanks for the pr |
About the PR
shuttle.cooldownccvar from the default of 10 seconds to 60 seconds.shuttle.arrivals_ftl_cooldown, defaulting at 10 seconds (to not break the arrivals system).Game Admin Notes
For game admins/admemes, you can bypass the FTL cooldown by vvwriting the shuttle grid's server ShuttleComponent, and setting FTLCooldownOverride to a value. This value will reflect the FTL cooldown length for future FTLs (it does not update while the shuttle is already cooling down).
The full command syntax is
vvwrite /entity/[uid]/Shuttle/FTLCooldownOverride [value], where a value of5would equal 5 seconds.Why / Balance
The primary goal is to prevent FTL spam to avoid combat encounters, without negatively impacting regular shuttle FTLing. At the original value of 10s, this both felt bad for attackers attempting to board a shuttle, as well as (in my opinion) feels excessively NRP.
Technical details
In doing this, I also had to breakout the
shuttle.cooldownupdate to also have a new ccvar,shuttle.arrivals_ftl_cooldown, so that the Arrivals shuttle does not get affected by this change. I believe this is the only edge case that needs to be accounted for.Media
I don't think this needs a video, but I can make one if requested.
Requirements
Breaking changes
Two changes have been made to server CCVars.Shuttle.cs's - an update to
shuttle.cooldownand the introduction ofshuttle.arrivals_ftl_cooldown.shuttle.cooldowndefault value has been updated from 10 seconds -> 60 seconds. This is the default cooldown on all non-arrivals shuttles.shuttle.arrivals_ftl_cooldowndefault value has been set to 10 seconds (which was the previous default of shuttle.cooldown). This is the default cooldown for only the arrivals shuttle.If your server has a custom
shuttle.cooldownset, make sure that you pick a newshuttle.arrivals_ftl_cooldownvariable that will work with the other arrivals variables. Notably,shuttle.arrivals_cooldownneeds to be longer thanshuttle.arrivals_ftl_cooldownto avoid the cooldown double cycling.Changelog
🆑
ADMIN: