SIMD-0444: Relax program data account check in migration#444
Open
febo wants to merge 8 commits intosolana-foundation:mainfrom
Open
SIMD-0444: Relax program data account check in migration#444febo wants to merge 8 commits intosolana-foundation:mainfrom
febo wants to merge 8 commits intosolana-foundation:mainfrom
Conversation
|
Hello febo! Welcome to the SIMD process. By opening this PR you are affirming that your SIMD has been thoroughly discussed and vetted in the SIMD discussion section. The SIMD PR section should only be used to submit a final technical specification for review. If your design / idea still needs discussion, please close this PR and create a new discussion here. This PR requires the following approvals before it can be merged:
Once all requirements are met, you can merge this PR by commenting |
febo
force-pushed
the
program-data-account-requirements
branch
from
3df133c to
1d00185
Compare
febo
force-pushed
the
program-data-account-requirements
branch
from
1d00185 to
de14574
Compare
febo
changed the title
buffalojoec
reviewed
Jan 9, 2026
Contributor
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
My diff looks big, but I mostly suggested three things:
- Don't mention the type of migration specifically. This check applies to all - current and future.
- Simplify the code snippets to only what we care about.
- Describe the resulting lamport accounting change.
Co-authored-by: Joe C <[email protected]>
Co-authored-by: Joe C <[email protected]>
Co-authored-by: Joe C <[email protected]>
Co-authored-by: Joe C <[email protected]>
febo
force-pushed
the
program-data-account-requirements
branch
from
7cbe779 to
586af7e
Compare
This was referenced Jan 9, 2026
buffalojoec
previously approved these changes
Jan 9, 2026
Co-authored-by: Joe C <[email protected]>
buffalojoec
previously approved these changes
Jan 12, 2026
mjain-jump
approved these changes
Jan 13, 2026
buffalojoec
approved these changes
Jan 30, 2026
topointon-jump
approved these changes
Jan 31, 2026
|
Thanks, topointon-jump! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.