runtime: Relax program data account check in migration#9891
runtime: Relax program data account check in migration#9891febo merged 4 commits intoanza-xyz:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9891 +/- ##
========================================
Coverage 82.6% 82.6%
========================================
Files 848 848
Lines 316763 316983 +220
========================================
+ Hits 261754 261972 +218
- Misses 55009 55011 +2 🚀 New features to boost your workflow:
|
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
|
can we title this with something more relevant to the change? folks shouldn't have to go to the simd to figure out whether a pr is relevant |
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
Implementation looks great! Let's just beef up the test coverage a bit.
|
|
||
| let program_data_address = get_program_data_address(program_address); | ||
|
|
||
| // The program data account should not exist. |
There was a problem hiding this comment.
ok nice this is what i was expecting to see
| *program_address, | ||
| )); | ||
| } | ||
| let program_data_account_lamports = if allow_prefunded { |
There was a problem hiding this comment.
the replicode here is annoying. not an issue for this change set, rather an issue for some previous, poorly reviewed change set
febo
changed the title
* Add feature gate * Add tests * Improve test coverage * Add zero-lamports tests back (cherry picked from commit 5390905) # Conflicts: # feature-set/src/lib.rs
…t of #9891) (#9998) * runtime: Relax program data account check in migration (#9891) * Add feature gate * Add tests * Improve test coverage * Add zero-lamports tests back (cherry picked from commit 5390905) # Conflicts: # feature-set/src/lib.rs * Fix conflict --------- Co-authored-by: febo <[email protected]>
4 participants
Problem
SIMD-0444 enables runtime-level program migrations when the target program data accounts is already funded, which currently it is not possible.
Summary of Changes
This PR adds a feature gate for SIMD-0444 and updates the migration validation to allow pre-funded program data accounts.