Skip to content

[Android][iOS] Don't handle events on the detector surface #3823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-piasecki merged 1 commit into from
Nov 20, 2025
Merged

[Android][iOS] Don't handle events on the detector surface #3823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...d/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerDetectorViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package com.swmansion.gesturehandler.react

import com.facebook.react.bridge.ReadableArray
import com.facebook.react.module.annotations.ReactModule
import com.facebook.react.uimanager.PointerEvents.Companion.parsePointerEvents
import com.facebook.react.uimanager.ThemedReactContext
import com.facebook.react.uimanager.ViewGroupManager
import com.facebook.react.uimanager.ViewManagerDelegate
Expand Down Expand Up @@ -45,4 +46,8 @@ class RNGestureHandlerDetectorViewManager :
view.onViewDrop()
super.onDropViewInstance(view)
}

override fun setPointerEvents(view: RNGestureHandlerDetectorView, pointerEventsStr: String?) {
view.pointerEvents = parsePointerEvents(pointerEventsStr)
}
}
8 changes: 8 additions & 0 deletions packages/react-native-gesture-handler/src/specs/RNGestureHandlerDetectorNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import type {
DirectEventHandler,
UnsafeMixed,
Double,
WithDefault,
} from 'react-native/Libraries/Types/CodegenTypes';
import type { ViewProps } from 'react-native';

Expand Down Expand Up @@ -47,6 +48,8 @@ export interface VirtualChildrenProps {
viewTag: Int32;
}

// @ts-expect-error WithDefault adds `| null` to the type, which doesn't align with ViewProps.pointerEvents
// Using Exclude to remove null from the type makes the error go away, but breaks codegen.
export interface NativeProps extends ViewProps {
onGestureHandlerEvent?: DirectEventHandler<GestureHandlerEvent>;
onGestureHandlerStateChange?: DirectEventHandler<GestureHandlerStateChangeEvent>;
Expand All @@ -59,6 +62,11 @@ export interface NativeProps extends ViewProps {
handlerTags: Int32[];
moduleId: Int32;
virtualChildren: VirtualChildrenProps[];

pointerEvents?: WithDefault<
'box-none' | 'none' | 'box-only' | 'auto',
'auto'
>;
}

export default codegenNativeComponent<NativeProps>('RNGestureHandlerDetector', {
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-gesture-handler/src/v3/detectors/NativeDetector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export function NativeDetector<THandlerData, TConfig>({

return (
<NativeDetectorComponent
pointerEvents={'box-none'}
// @ts-ignore This is a type mismatch between RNGH types and RN Codegen types
onGestureHandlerStateChange={
gesture.detectorCallbacks.onGestureHandlerStateChange
Expand Down
1 change: 1 addition & 0 deletions ...t-native-gesture-handler/src/v3/detectors/VirtualDetector/InterceptingGestureDetector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ export function InterceptingGestureDetector<THandlerData, TConfig>({
return (
<InterceptingDetectorContext value={contextValue}>
<NativeDetectorComponent
pointerEvents={'box-none'}
// @ts-ignore This is a type mismatch between RNGH types and RN Codegen types
onGestureHandlerStateChange={useMemo(
() => createGestureEventHandler('onGestureHandlerStateChange'),
Expand Down
Loading