[Android][iOS] Don't handle events on the detector surface #3823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
approved these changes
Nov 19, 2025
j-piasecki
deleted the
@jpiasecki/dont-handle-events-on-detector-surface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents
NativeDetectorfrom reacting to events that happen on its surface but not on any of its children. This should match the behavior from the V2 API, and feels more like an "expected" result.This doesn't affect the web since
display: contentsthere isn't subject to our hacks and the detector doesn't create a box. The behavior after this PR should be consistent across the platforms.Since codegen is not perfect, to put it lightly, I had to redeclare
pointerEventsin the spec and handle the setter on Android. The only base class that does it automatically isReactViewManager, but we need to create aViewGroupto accept children.Test plan
Screen.Recording.2025-11-19.at.10.24.27.mov
Screen.Recording.2025-11-19.at.10.45.17.mov
Screen.Recording.2025-11-19.at.10.23.09.mov
Screen.Recording.2025-11-19.at.10.44.18.mov