Rework/devel/fd bbmd write hostname choice #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metelik
commented
Jan 10, 2025
metelik
commented
- Re-work as suggested in Devel/nc fd bbmd address choice 2 bacnet-stack/bacnet-stack#887
- Bugfix to logic behind OUT_OF_RANGE error
- Unit tests
added 2 commits
January 9, 2025 14:03
metelik
requested review from
PeterJeaiem,
adrigonzo,
alanj853,
bjmurphySE2,
caseybracken,
danielmcm98 and
dcmaverick
alanj853
approved these changes
Jan 10, 2025
adrigonzo
approved these changes
Jan 10, 2025
PeterJeaiem
reviewed
Jan 10, 2025
PeterJeaiem
approved these changes
Jan 10, 2025
metelik
force-pushed
the
rework/devel/fd_bbmd_write_hostname_choice
branch
from
e3b0df4 to
7227406
Compare
metelik
force-pushed
the
rework/devel/fd_bbmd_write_hostname_choice
branch
from
47115c8 to
96880d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.