strncpy instead of strcpy

Tomasz Kazimierz Motyl · Tomasz Kazimierz Motyl · commit e3b0df4a07c4 · 2025-01-10T15:14:39.000Z
diff --git a/src/bacnet/hostnport.c b/src/bacnet/hostnport.c
@@ -1218,7 +1218,8 @@ bool bacnet_is_valid_hostname(const BACNET_CHARACTER_STRING *const hostname)
     {
         char fqdn_copy[MAX_CHARACTER_STRING_BYTES + 1];
         char *label = NULL;
-        strcpy(fqdn_copy, val); /* Make a copy to manipulate */
+
+        strncpy(fqdn_copy, vali, sizeof(fqdn_copy) - 1); /* Make a copy to manipulate */
 
         label = strtok(fqdn_copy, "."); /* Split FQDN by '.' */
 

Original file line number	Diff line number	Diff line change
`@@ -1218,7 +1218,8 @@ bool bacnet_is_valid_hostname(const BACNET_CHARACTER_STRING *const hostname)`
`1218`	`1218`	`{`
`1219`	`1219`	`char fqdn_copy[MAX_CHARACTER_STRING_BYTES + 1];`
`1220`	`1220`	`char *label = NULL;`
`1221`		`- strcpy(fqdn_copy, val); /* Make a copy to manipulate */`
	`1221`	`+`
	`1222`	`+ strncpy(fqdn_copy, vali, sizeof(fqdn_copy) - 1); /* Make a copy to manipulate */`
`1222`	`1223`
`1223`	`1224`	`label = strtok(fqdn_copy, "."); /* Split FQDN by '.' */`
`1224`	`1225`