preliminary cleanup for split_str_once refactor#7258
Open
Goober5000 wants to merge 2 commits intoscp-fs2open:masterfrom
Open
preliminary cleanup for split_str_once refactor#7258Goober5000 wants to merge 2 commits intoscp-fs2open:masterfrom
Goober5000 wants to merge 2 commits intoscp-fs2open:masterfrom
Conversation
Goober5000
added
the
cleanup
Goober5000
force-pushed
the
split_str_once_preliminary_cleanup
branch
6 times, most recently
from
c2d4853 to
4855a38
Compare
Goober5000
added a commit
to Goober5000/fs2open.github.com
that referenced
this pull request
Mar 3, 2026
When a header in the PCH include chain is analysed as the main source file, the `-include` flag causes it to be parsed twice in the same translation unit. `#pragma once` cannot prevent this for the main file, resulting in redefinition errors. Use a sanitized compile_commands.json (with `-include`/`-include-pch` removed) for header files only. Claude's solution to the clang-tidy redefinition errors in scp-fs2open#7258 as well as a few previous PRs over the years.
Goober5000
force-pushed
the
split_str_once_preliminary_cleanup
branch
from
4855a38 to
4f62b5b
Compare
String processing enhancement prerequisites for the upcoming `split_str_once` PR. 1. Add overloads of some string processing functions with a length parameter, to allow processing of substrings of C-strings 2. Add overloads of gr_printf that work with string lengths 3. Add constructors to `HUD_message_data` and `line_node` 4. Rename "size" to "len" in `vm_strndup` for clarity 5. Fill in some string attribute annotations 6. Make the rest of the HUD render functions `const` 7. Removed unneeded circular #includes in code/globalincs/memory/
Goober5000
force-pushed
the
split_str_once_preliminary_cleanup
branch
from
4f62b5b to
16297bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String processing enhancement prerequisites for the upcoming
split_str_oncePR.HUD_message_dataandline_nodevm_strndupfor clarityconst