Strip PCH forced-include flags when clang-tidy analyses header files#7260
Closed
Goober5000 wants to merge 1 commit intoscp-fs2open:masterfrom
Closed
Strip PCH forced-include flags when clang-tidy analyses header files#7260Goober5000 wants to merge 1 commit intoscp-fs2open:masterfrom
Goober5000 wants to merge 1 commit intoscp-fs2open:masterfrom
Conversation
When a header in the PCH include chain is analysed as the main source file, the `-include` flag causes it to be parsed twice in the same translation unit. `#pragma once` cannot prevent this for the main file, resulting in redefinition errors. Use a sanitized compile_commands.json (with `-include`/`-include-pch` removed) for header files only. Claude's solution to the clang-tidy redefinition errors in scp-fs2open#7258 as well as a few previous PRs over the years.
Goober5000
added
fix
Contributor
Author
|
After further analysis, this won't actually work, since stripping the PCH information also removes header files needed to compile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a header in the PCH include chain is analysed as the main source file, the
-includeflag causes it to be parsed twice in the same translation unit.#pragma oncecannot prevent this for the main file, resulting in redefinition errors. Use a sanitized compile_commands.json (with-include/-include-pchremoved) for header files only.Claude's solution to the clang-tidy redefinition errors in #7258 as well as a few previous PRs over the years.