Fix ccall type-punning and mcall division by zero#2530
Merged
pd3 merged 1 commit intosamtools:developfrom Mar 31, 2026
Merged
Conversation
ccall.c: Change `tmpi` from float to int32_t so that bcf_update_info_int32() receives actual integer bits instead of reinterpreting float bits as an int32. mcall.c: Guard the MQ calculation against division by zero when all DP4 counts are zero, consistent with the existing check in test16_core().
sirus20x6
force-pushed
the
fix/ccall-mcall-bugs
branch
from
1127269 to
ae662c5
Compare
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmpideclaration fromfloattoint32_tinccall.c— was passed tobcf_update_info_int32which interpreted float bit pattern as garbage integer for CLR tagmcall.cbefore dividing by sum of DP4 counts — producesmq = 0when depth is zero, matching the pattern intest16_coreTest plan