Skip to content

add require_up_to_date_branches to v1 api#2364

Merged
marcoieni merged 1 commit intomainfrom
add--to-v1-api
Mar 31, 2026
Merged

add require_up_to_date_branches to v1 api#2364
marcoieni merged 1 commit intomainfrom
add--to-v1-api

Conversation

@marcoieni
Copy link
Copy Markdown
Member

@marcoieni marcoieni commented Mar 31, 2026 •
edited
Loading

Before merging #2362, we merge this PR and update triagebot.

marcoieni
marcoieni commented Mar 31, 2026
View reviewed changes
rust_team_data/src/v1.rs
pub merge_bots: Vec<MergeBot>,
pub allowed_merge_apps: Vec<MergeBot>,
#[serde(default, skip_serializing_if = "is_false")]
pub require_up_to_date_branches: bool,
Copy link
Copy Markdown
Member Author

@marcoieni marcoieni Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't serialize if false, so that merging this change doesn't break triagebot.

Copy link
Copy Markdown
Member

@Kobzol Kobzol Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't matter anyway, as new fields shouldn't break downstream consumers, they will be ignored.

@marcoieni marcoieni mentioned this pull request Mar 31, 2026
Merged
2 tasks
@marcoieni marcoieni changed the title add to v1 api add require_up_to_date_branches to v1 api Mar 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

Dry-run check results 

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github

@marcoieni marcoieni marked this pull request as ready for review March 31, 2026 13:50
@rustbot
Copy link
Copy Markdown

rustbot commented Mar 31, 2026

rust_team_data/src/v1.rs has been modified, it is used (as a git dependency) by multiple sub-projects like triagebot, the www.rust-lang.org website and others.

If you are changing the data structures, please make sure that the changes are not going to break serde deserialization (adding a field is fine; removing or renaming a field isn't).

If you must do a breaking change to the format, make sure to coordinate it with all the users of the rust_team_data crate.

Kobzol
Kobzol approved these changes Mar 31, 2026
View reviewed changes
rust_team_data/src/v1.rs
pub merge_bots: Vec<MergeBot>,
pub allowed_merge_apps: Vec<MergeBot>,
#[serde(default, skip_serializing_if = "is_false")]
pub require_up_to_date_branches: bool,
Copy link
Copy Markdown
Member

@Kobzol Kobzol Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't matter anyway, as new fields shouldn't break downstream consumers, they will be ignored.

@marcoieni marcoieni added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit bd16e09 Mar 31, 2026
3 checks passed
@marcoieni marcoieni mentioned this pull request Apr 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ubiratansoares ubiratansoares ubiratansoares approved these changes

@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum Mark-Simulacrum is a code owner

@emilyalbini emilyalbini Awaiting requested review from emilyalbini emilyalbini is a code owner

@jdno jdno Awaiting requested review from jdno jdno is a code owner

+1 more reviewer

@Kobzol Kobzol Kobzol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcoieni @rustbot @ubiratansoares @Kobzol