support require up-to-date branches option

[marcoieni]

This setting was set manually from the UI. With this PR we add in team the ability to set this field via toml.

For the docs, check the field requiresStrictStatusChecks in: https://docs.github.com/en/graphql/reference/objects#branchprotectionrule

• Blocked by add require_up_to_date_branches to v1 api #2364 and update team data to support require branch up to date triagebot#2359

Why is the dry run not empty?

This PR disables this field for repositories that don't have checks. As you can see from the settings page, this field does nothing in this case:

• When reviewing this PR, I checked that all the repositories shown in the dry run don't have any required checks.

[github-actions]

Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github
[INFO  rust_team::sync] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/arewewebyet':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/async-fundamentals-initiative':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/book':
      Branch Protections:
          main
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/calendar':
      Branch Protections:
          main
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/calendar-generation':
      Branch Protections:
          main
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/cargo-bisect-rustc':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/compiler-team':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/crates.io-index':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/docs.rs':
      Branch Protections:
          main
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/ena':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/futures-rs':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/impl-trait-utils':
      Branch Protections:
          main
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/leadership-council':
      Branch Protections:
          main
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/llvm-project':
      Branch Protections:
          rustc/*
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/portable-simd':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/project-stable-mir':
      Branch Protections:
          main
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/rfcs':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/rust-playground':
      Branch Protections:
          main
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/rustc-hash':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/rustc-stable-hash':
      Branch Protections:
          main
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/this-week-in-rust':
      Branch Protections:
          main
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/wg-async':
      Branch Protections:
          master
            Require branches to be up to date: true => false
    📝 Editing repo 'rust-lang/wg-macros':
      Branch Protections:
          main
            Require branches to be up to date: true => false

[marcoieni]

I named this differently from the github api because imo this name is better

[marcoieni]

Branch protections mentioned in the dry run:

• rust-lang/arewewebyet master: link
• rust-lang/async-fundamentals-initiative master: link
• rust-lang/book main: link
• rust-lang/calendar main: link
• rust-lang/calendar-generation main: link
• rust-lang/cargo-bisect-rustc master: link
• rust-lang/compiler-team master: link
• rust-lang/crates.io-index master: link
• rust-lang/docs.rs main: link
• rust-lang/ena master: link
• rust-lang/futures-rs master: link
• rust-lang/impl-trait-utils main: link
• rust-lang/leadership-council main: link
• rust-lang/llvm-project rustc/*: link
• rust-lang/portable-simd master: link
• rust-lang/project-stable-mir main: link
• rust-lang/rfcs master: link
• rust-lang/rust-playground main: link
• rust-lang/rustc-stable-hash main: link
• rust-lang/rustc-hash master: link
• rust-lang/this-week-in-rust main: link
• rust-lang/wg-async master: link
• rust-lang/wg-macros main: link

[marcoieni]

Screenshots of Branch protections mentioned in the dry run

[marcoieni]

not needed anymore, we can always send this field to triagebot.

[rustbot]

rust_team_data/src/v1.rs has been modified, it is used (as a git dependency) by multiple sub-projects like triagebot, the www.rust-lang.org website and others.

If you are changing the data structures, please make sure that the changes are not going to break serde deserialization (adding a field is fine; removing or renaming a field isn't).

If you must do a breaking change to the format, make sure to coordinate it with all the users of the rust_team_data crate.

[ubiratansoares]

This PR disables this field for repositories that don't have checks. As you can see from the settings page, this field does nothing in this case

[EDIT] : I confirmed my previous comment here was inaccurate, because I was working with a wrong assumption. I think I need a coffee :P