-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add Custom-UI-Anchors plugin repository details #10115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Provides customizable UI anchors to handle client resizing
|
New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
Reflection is not allowed. Your method for snapping overlays is also highly wrong for being in client tick. I don't think this is possible as a hub plugin. |
|
if you can't produce a functional version of this without reflection we're not going to be able to accept it |
Implemented a new approach to capture overlays without using reflection by making the customizer overlay drag-targetable and tracking overlays when they are dragged. Added onDrag callback to capture overlay references, a runtime map to store tracked overlays, and scanAndReacquireOverlays method to restore overlay tracking on startup using the public anyMatch API. Includes cleanup logic to remove stale overlay references.
|
Your update will not work on overlays being added/removed, nor will it work when you restart the client/plugin. There's also the fact you will still be clashing with the the core overlay renderer between render calls. Like I said previously, I seriously do not think this will work as a hub plugin and would appreciate you discussing it with us. |
Would the RuneLite team consider making the following public/additions to enable this use case properly?
Basically exposing what I was doing with reflection, but in a safe way. |
|
We generally don't expose things exclusively for hub plugins that aren't already public. Considering overlay rendering is internally managed, I'm not sure it make sense to expose all overlays nor a hook due to potential issues of having to make sure the hub plugin is absolutely correct. At that point, it should just be managed on core. |
The only thing that comes to mind that may make it useful to make these public would be plugins that are natural extensions of wanting to manipulate UI. Basically, I can foresee a plugin that saves profiles of different UI setups or community hubs for sharing these UIs presets/templates (kind of like World of Warcraft has) I would I imagine that next use case wouldn't end up in core functionality, right? |
|
That would be part of the core profiles, I'd imagine. |
Provides customizable UI anchors to handle client resizing