Skip to content

Conversation

@Car-Role
Copy link

@Car-Role Car-Role commented Jan 9, 2026

Core version for this PR

runelite/plugin-hub#10115

@Car-Role Car-Role changed the title initial custom anchors core initial custom UI anchors core Jan 9, 2026
@raiyni
Copy link
Member

raiyni commented Jan 9, 2026

This pr has the same fundamental flaws as your hub pr and seeing as it looks LLM generated, I'm not sure you understand what I mean.

@Car-Role
Copy link
Author

Car-Role commented Jan 9, 2026

This pr has the same fundamental flaws as your hub pr and seeing as it looks LLM generated, I'm not sure you understand what I mean.

I appreciate the feedback, but I'm having trouble understanding the technical issues you're describing. I'm not experienced with RuneLite's internal architecture. I do not know the delineation of what "core" means in terms of rendering encapsulation. I have no clue how a complex feature would function without some level of UI housed in a side panel, so, I started there. I do not expect this to be merged in one pass. Talking down to someone who is volunteering their time and contributing to a project shouldn't be acceptable behavior.

Can you provide more specific technical details about:

  • What "clashing with the core overlay renderer" means in practice with specifics to what has been built
  • Where in the rendering pipeline this positioning logic should hook in

@Car-Role
Copy link
Author

This pr has the same fundamental flaws as your hub pr and seeing as it looks LLM generated, I'm not sure you understand what I mean.

refactored to use OverlayAnchorManager and integrate anchor rendering into OverlayRenderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants