Skip to content

Add 'all' as default DID search type (#446) #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Haiderkhan64 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −4
Open

Add 'all' as default DID search type (#446) #532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/component-library/features/search/DIDSearchPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ interface SearchPanelProps {
isRunning: boolean;
}

type SearchType = DIDType | 'all';

export const DIDSearchPanel = (props: SearchPanelProps) => {
// Try retrieving initial search parameters
let initialScope: string | undefined, initialName: string | undefined;
Expand All @@ -42,7 +44,7 @@ export const DIDSearchPanel = (props: SearchPanelProps) => {

const [scope, setScope] = useState<string | null>(initialScope ?? null);
const [name, setName] = useState<string | null>(initialName ?? null);
const [type, setType] = useState<DIDType>(DIDType.DATASET);
const [type, setType] = useState<SearchType>('all');

const scopeInputRef = useRef<HTMLInputElement>(null);
const nameInputRef = useRef<HTMLInputElement>(null);
Expand Down Expand Up @@ -84,8 +86,10 @@ export const DIDSearchPanel = (props: SearchPanelProps) => {

const params = new URLSearchParams({
query: `${scope}${SCOPE_DELIMITER}${name}`,
type: type,
});
if (type !== 'all') {
params.append('type', type);
}

const url = '/api/feature/list-dids?' + params;
props.startStreaming(url);
Expand All @@ -111,12 +115,13 @@ export const DIDSearchPanel = (props: SearchPanelProps) => {
return (
<div className="flex flex-col space-y-2 w-full md:items-start md:flex-row md:space-y-0 md:space-x-2">
<div className="flex flex-col grow sm:flex-row space-y-2 sm:space-x-2 sm:space-y-0">
<Select onValueChange={value => setType(value as DIDType)} defaultValue={type}>
<Select onValueChange={value => setType(value as SearchType)} defaultValue={type}>
<SelectTrigger className="w-full sm:w-48">
<SelectValue placeholder="Type" />
</SelectTrigger>
<SelectContent>
<SelectGroup>
<SelectItem value="all">All</SelectItem>
<SelectItem value={DIDType.CONTAINER}>Container</SelectItem>
<SelectItem value={DIDType.DATASET}>Dataset</SelectItem>
<SelectItem value={DIDType.FILE}>File</SelectItem>
Expand Down Expand Up @@ -151,4 +156,4 @@ export const DIDSearchPanel = (props: SearchPanelProps) => {
<SearchButton className="sm:w-full md:w-48" isRunning={props.isRunning} onStop={onStop} onSearch={onSearch} />
</div>
);
};
};