Add 'all' as default DID search type (#446)#532
Add 'all' as default DID search type (#446)#532Haiderkhan64 wants to merge 1 commit intorucio:masterfrom
Conversation
|
Hey @Haiderkhan64 , was this issue discussed ? I believe we are not using 'all' to prevent database queries having to parse extremely large results. |
|
Hi @maany, thanks for the feedback! I implemented 'all' as the default DID search type per #446’s request to allow listing all DID types intuitively. I wasn’t aware of prior discussions about avoiding 'all' due to large result sets—my apologies if I missed that context. To address this, would it be better to:
I noted in the PR that the API (/api/feature/list-dids) might need adjustment to support queries without a 'type' parameter. Happy to adjust based on your guidance—let me know how to proceed! |
|
Sorry to jump in, but have you considered using some kind of client caching mechanism to remember the selection of the DID type? I am frequently changing from dataset to file and this would really make usage more confortable, and I guess it would also partially address #446. Would love to hear your thoughts on this @maany |
|
@lobis, thanks for the suggestion! I agree that a client-side caching mechanism to remember the DID type selection would make the UI more comfortable, especially for frequent switches like 'dataset' to 'file'. I could add this using @maany, I’m still awaiting your input on the large result set concern. Combining caching with 'all' (e.g., default to 'all' but cache the last choice, plus a Let me know—I’m ready to update the PR accordingly! |
Modified DIDSearchPanel.tsx to add 'all' as a default DID search type. Introduced SearchType union to extend DIDType with 'all'. Updated onSearch to omit the 'type' parameter when 'all' is selected, allowing the API to fetch all DID types. Resolves #446.
Note: The API (/api/feature/list-dids) may need an update to handle queries without a 'type' parameter, as noted in the issue.