Skip to content

feat(activerecord): Add types for ActiveRecord::Relation#reorder and ActiveRecord::Relation#unscope#970

Merged
github-actions[bot] merged 1 commit intoruby:mainfrom
sanfrecce-osaka:add-reorder-and-unscope
Jan 7, 2026
Merged

feat(activerecord): Add types for ActiveRecord::Relation#reorder and ActiveRecord::Relation#unscope#970
github-actions[bot] merged 1 commit intoruby:mainfrom
sanfrecce-osaka:add-reorder-and-unscope

Conversation

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

@sanfrecce-osaka Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @Little-Rubyist, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Thanks for your review, @ksss!

@sanfrecce-osaka, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@sanfrecce-osaka
Copy link
Contributor Author

/merge

@github-actions github-actions bot merged commit d524dec into ruby:main Jan 7, 2026
7 checks passed
@sanfrecce-osaka
Copy link
Contributor Author

@ksss

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants