feat(activerecord): Add types for ActiveRecord::Relation#reorder and ActiveRecord::Relation#unscope#970
Conversation
…ActiveRecord::Relation#unscope Similar to ruby#858, I add types to both interfaces and modules. Because interfaces are still used by some applications and gems. e.g. - https://github.com/ksss/orthoses-rails/blob/v1.13.2/lib/orthoses/active_record/relation.rb#L40 - https://github.com/ksss/orthoses-rails/blob/v1.13.2/lib/orthoses/active_record/relation.rb#L52 - https://github.com/kaigionrails/conference-app/blob/331d122645f4c046702998ddec4b9f2e194fa5e1/sig/rbs_rails/app/models/speakers_talk.rbs#L2 added method implementations are below - https://github.com/rails/rails/blob/v8.1.1/activerecord/lib/active_record/relation/query_methods.rb#L743-L757 - https://github.com/rails/rails/blob/v8.1.1/activerecord/lib/active_record/relation/query_methods.rb#L773-L809
|
@sanfrecce-osaka Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
|
Thanks for your review, @ksss! @sanfrecce-osaka, @ksss This PR is ready to be merged. |
|
/merge |
|
Thanks for your review! |

Similar to #858, I add types to both interfaces and modules. Because interfaces are still used by some applications and gems.
e.g.
added method implementations are below