Commit d524dec
authored
feat(activerecord): Add types for ActiveRecord::Relation#reorder and ActiveRecord::Relation#unscope (#970)
Similar to #858, I add types to both interfaces and modules.
Because interfaces are still used by some applications and gems.
e.g.
- https://github.com/ksss/orthoses-rails/blob/v1.13.2/lib/orthoses/active_record/relation.rb#L40
- https://github.com/ksss/orthoses-rails/blob/v1.13.2/lib/orthoses/active_record/relation.rb#L52
- https://github.com/kaigionrails/conference-app/blob/331d122645f4c046702998ddec4b9f2e194fa5e1/sig/rbs_rails/app/models/speakers_talk.rbs#L2
added method implementations are below
- https://github.com/rails/rails/blob/v8.1.1/activerecord/lib/active_record/relation/query_methods.rb#L743-L757
- https://github.com/rails/rails/blob/v8.1.1/activerecord/lib/active_record/relation/query_methods.rb#L773-L8091 parent 2609a75 commit d524dec
File tree
4 files changed
+26
-0
lines changed- gems/activerecord
- 7.2
- _test
- 8.0
- _test
4 files changed
+26
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
87 | 92 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
| 231 | + | |
| 232 | + | |
231 | 233 | | |
232 | 234 | | |
233 | 235 | | |
| |||
236 | 238 | | |
237 | 239 | | |
238 | 240 | | |
| 241 | + | |
| 242 | + | |
239 | 243 | | |
240 | 244 | | |
241 | 245 | | |
| |||
252 | 256 | | |
253 | 257 | | |
254 | 258 | | |
| 259 | + | |
| 260 | + | |
255 | 261 | | |
256 | 262 | | |
257 | 263 | | |
| |||
350 | 356 | | |
351 | 357 | | |
352 | 358 | | |
| 359 | + | |
| 360 | + | |
353 | 361 | | |
354 | 362 | | |
355 | 363 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
87 | 92 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
| 231 | + | |
| 232 | + | |
231 | 233 | | |
232 | 234 | | |
233 | 235 | | |
| |||
236 | 238 | | |
237 | 239 | | |
238 | 240 | | |
| 241 | + | |
| 242 | + | |
239 | 243 | | |
240 | 244 | | |
241 | 245 | | |
| |||
252 | 256 | | |
253 | 257 | | |
254 | 258 | | |
| 259 | + | |
| 260 | + | |
255 | 261 | | |
256 | 262 | | |
257 | 263 | | |
| |||
350 | 356 | | |
351 | 357 | | |
352 | 358 | | |
| 359 | + | |
| 360 | + | |
353 | 361 | | |
354 | 362 | | |
355 | 363 | | |
| |||
0 commit comments