Remove target_pixi again & address env var changes that caused rebuilds
#11826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@rerun-bot full-check |
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/19175265974 |
Wumpf
added
the
exclude from changelog
Wumpf
changed the title
target_pixi againtarget_pixi again
Wumpf
changed the title
target_pixi againtarget_pixi again & address env var changes that caused rebuilds
ntjohnson1
reviewed
Nov 7, 2025
| # https://pyo3.rs/main/building-and-distribution.html#configuring-the-python-version | ||
| PYO3_PYTHON = "python" | ||
|
|
||
| # TODO(rust-lang/stacker#127): Work around until wasm build on mac is resolved |
Member
There was a problem hiding this comment.
Mostly an FYI that stacker took my PR. Doing a cargo tree --invert stacker shows that everything depends on it indirectly through recursive which doesn't pin the patch version. That means on the next build of datafusion > 50.3 we should no longer need the AR workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got annoyed by having two (four with _wasm variants) target folders around because of unintentionally switching between the pixi environment & "raw" invocations.
This PR removes
target_pixiagain and addresses the reason we introduced this in the first place: there are certain environment variables in the pixi environment that get picked up by rust build scripts.Using
CARGO_LOG=cargo::core::compiler::fingerprint=infoI identified two:AR: we set this on MacOS to solve some issues with our wasm build, see Fix building Web Viewer on macOS #10828CONDA_PREFIX: py03 uses this to govern which python install to useThe fix in both cases is to move those env vars to
.cargo/config.toml. ForARthat's trivial, forCONDA_PREFIXnot so much! Every pixi environment has its own conda prefix (and yes that would also cause rebuilds between pixi environments!). So instead I'm settingPYO3_PYTHONwhich directly governs which python install pyo3 uses for linking. Here be dragons (a little bit ;-)): This means we no longer fix the python version used and instead rely on whateverpythonpoints to.things I tried to verify this:
pixi run cargo check&cargo checknot causing to rebuild each otherpixi run py-buildthen execute some script that needs a Rerun installpixi run rerun-webout of pragmatism I left the pixi target folder in git & prettier ignore lists 🤷