bug: Use repr() for chat tool calls when exporting markdown#30
Merged
bug: Use repr() for chat tool calls when exporting markdown#30
repr() for chat tool calls when exporting markdown#30Conversation
If we're putting the value in a python code block, then it is safe to assume the code can be run. `repr()` should return eval-able objects (which do not need an extra layer of quoting).
Contributor
Author
|
Still isn't what I want |
Contributor
Author
|
Need to use |
Contributor
Author
|
😂 Link |
Contributor
Author
|
The test that is failing is a false-positive. I re-ran it once and it did not improve. 🙄 |
Contributor
Author
|
Got it to pass by waiting. woot |
cpsievert
approved these changes
Jan 8, 2025
repr() on for chat's valuerepr() for chat tool calls when exporting markdown
schloerke
added a commit
that referenced
this pull request
Jan 8, 2025
* main: bug: Use `repr()` for chat tool calls when exporting markdown (#30)
3 tasks
cpsievert
added a commit
that referenced
this pull request
Mar 7, 2025
cpsievert
added a commit
that referenced
this pull request
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we're putting the value in a python code block, then it is safe to assume the code can be run.
repr()should return eval-able objects (which do not need an extra layer of quoting).First seen in :
Desired output:
When using
repr(), strings will be quoted. JSON will be given as is.